Change subjectId List to Iterable #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
....measure-hapi/src/main/java/org/opencds/cqf/cql/evaluator/measure/r4/R4MeasureProcessor.java
Outdated
Show resolved
Hide resolved
...re-hapi/src/main/java/org/opencds/cqf/cql/evaluator/measure/dstu3/Dstu3MeasureProcessor.java
Outdated
Show resolved
Hide resolved
|
Showing some conflicts, needs to be resolved |
....measure-hapi/src/main/java/org/opencds/cqf/cql/evaluator/measure/r4/R4MeasureProcessor.java
Outdated
Show resolved
Hide resolved
....measure-hapi/src/main/java/org/opencds/cqf/cql/evaluator/measure/r4/R4MeasureProcessor.java
Outdated
Show resolved
Hide resolved
...easure/src/main/java/org/opencds/cqf/cql/evaluator/measure/common/BaseMeasureEvaluation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid memory issues with large datasets, it was required to alter subjectId list to an iterable. This required updating all references of List to Iterable for measure evaluation. Also altered how threaded evaluation works, now instead of sizing the list and breaking it in chunks, it will create batches as they iterate through the dataset. Outcome should be improved performance